Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assorted enhancements of remap_restarts.py package (EASE, SLES15, NAS, lake/landice log) #43

Merged
merged 29 commits into from
Jan 24, 2024
Merged

Assorted enhancements of remap_restarts.py package (EASE, SLES15, NAS, lake/landice log) #43

merged 29 commits into from
Jan 24, 2024

Conversation

gmao-rreichle
Copy link
Contributor

@gmao-rreichle gmao-rreichle commented Dec 6, 2023 •
edited
Loading

  1. Add EASE grid option to remapping of surface restarts in remap_restarts.py package (to facilitate use of the package in ldas_setup) [done]
  2. Added support for SLES15 [done]
  3. Added support for NAS site [done]
  4. Added log fo remap_lake_landice_saltwater [done]
  5. Added land-only option [done]

@gmao-rreichle gmao-rreichle added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. enhancement New feature or request labels Dec 6, 2023
@weiyuan-jiang
Copy link
Contributor

The last commit addresses issue #39 and issue #40

@weiyuan-jiang weiyuan-jiang marked this pull request as ready for review December 20, 2023 13:43
@weiyuan-jiang weiyuan-jiang requested review from a team as code owners December 20, 2023 13:43
tclune
tclune reviewed Dec 20, 2023
View reviewed changes
pre/CMakeLists.txt Outdated Show resolved Hide resolved
tclune
tclune reviewed Dec 20, 2023
View reviewed changes
Copy link
Contributor

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asked question inline.

@gmao-rreichle gmao-rreichle requested a review from a team as a code owner December 20, 2023 14:33
@gmao-rreichle gmao-rreichle mentioned this pull request Dec 20, 2023
Merged
@weiyuan-jiang
Copy link
Contributor

Asked question inline.

@tclune . I make it look better now

@weiyuan-jiang
Copy link
Contributor

@gmao-rreichle It is ready for review

@tclune tclune self-requested a review December 20, 2023 19:31
tclune
tclune previously approved these changes Dec 20, 2023
View reviewed changes
@gmao-rreichle gmao-rreichle changed the title Add functionality for remapping EASE grid restarts to remap_restarts.py package Assorted enhancements of remap_restarts.py package (EASE, SLES15, NAS, lake/landice log) Dec 20, 2023
@gmao-rreichle gmao-rreichle marked this pull request as draft January 10, 2024 15:07
This was referenced Jan 17, 2024
Closed
Closed
Closed
@biljanaorescanin biljanaorescanin marked this pull request as ready for review January 17, 2024 20:54
@biljanaorescanin
Copy link
Contributor

I've retested, and all automated tests passed. @sdrabenh this is ready for you.

@gmao-rreichle
Copy link
Contributor Author

@sdrabenh: I initiated the PR and cannot formally approve it. @biljanaorescanin tested it after the latest commit by @weiyuan-jiang yesterday. This PR is all set now. Please go ahead and merge if it looks ok to you.

@mathomp4 mathomp4 self-requested a review January 24, 2024 20:11
@sdrabenh sdrabenh merged commit 61009d5 into main Jan 24, 2024
7 checks passed
@sdrabenh sdrabenh deleted the feature/wjiang/add_ease_grid branch January 24, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biljanaorescanin biljanaorescanin biljanaorescanin approved these changes

@sdrabenh sdrabenh sdrabenh approved these changes

@mathomp4 mathomp4 mathomp4 approved these changes

@weiyuan-jiang weiyuan-jiang weiyuan-jiang left review comments

@tclune tclune tclune left review comments

Assignees
No one assigned
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gmao-rreichle @weiyuan-jiang @biljanaorescanin @mathomp4 @tclune @sdrabenh