Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare for sparse checkout #58

Merged
merged 4 commits into from
Feb 21, 2024
Merged

prepare for sparse checkout #58

merged 4 commits into from
Feb 21, 2024

Conversation

weiyuan-jiang
Copy link
Contributor

No description provided.

@weiyuan-jiang weiyuan-jiang added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Feb 15, 2024
@gmao-rreichle gmao-rreichle mentioned this pull request Feb 16, 2024
Merged
@weiyuan-jiang weiyuan-jiang marked this pull request as ready for review February 20, 2024 12:47
@weiyuan-jiang weiyuan-jiang requested review from a team as code owners February 20, 2024 12:47
mathomp4
mathomp4 reviewed Feb 20, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@mathomp4
Copy link
Member

@weiyuan-jiang I just pushed a fix for the failing coupled runs. I think it was just a simple missing 's'.

@biljanaorescanin
Copy link
Contributor

  1. We are able to run GEOSldas with no errors
  2. If we run one day of develop GEOSldas vs one day when using these two branches output is zero diff
    image

@mathomp4 mathomp4 requested a review from a team February 21, 2024 14:36
@sdrabenh sdrabenh merged commit 2e6fe63 into main Feb 21, 2024
5 of 7 checks passed
@sdrabenh sdrabenh deleted the feature/wjiang/for_sparse branch February 21, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 left review comments

@sdrabenh sdrabenh sdrabenh approved these changes

@bena-nasa bena-nasa bena-nasa approved these changes

Assignees
No one assigned
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@weiyuan-jiang @mathomp4 @biljanaorescanin @bena-nasa @sdrabenh