-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/bweir/#79 codas #119
Conversation
…codas Been a while, just updating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmake changes ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My guess is that by you having moved CO2 (and CO, but I don’t care about it) around you caused the code not to take CO2 correctly, with the consequence that CRTM is likely not seeing CO2 as it should see. This is my GUESS, of what’s is happening. I am in the process of testing my hypothesis.
But you cannot implement something and “think” that all you did has nothing to do w/ the typical things and assume it reproduces the standard cases: you need to test!
Also, I am rather puzzled by the way you are using the GSI to tracer analysis. I would have imagined that you would not need any changes in standard anavinfo at all. On What I would have expected is for you to add a tracer-specific anavinfo that would exercise mainly the tracer components. That is,
That would have something like this in the state_vector table:
state_vector::
!var level itracer source funcof
prse 73 0 met_guess prse
ps 1 0 met_guess prse
co2 72 1 chem_guess co2
ch4 72 1 chem_guess ch4
co 72 1 chem_guess co
clo 72 1 chem_guess clo
ch3cl 72 1 chem_guess ch3cl
n2o 72 1 chem_guess n2o
hno3 72 1 chem_guess hno3
hcl 72 1 chem_guess hcl
h2o 72 1 chem_guess h2o
::
That is, no meteorological quantities; you would need ps and the 3d-pressures since you need them for the vertical coordinates.
I think we need talk …
Here are also some general comments:
I have a number of other smaller concerns and comments, but the items above make up the most important stuff. |
Brad, just to let you know that I made changes that make the code reproduce the original GSI - the one presently in develop.
Now what I am doing next - already have it in my sandbox is a setting that runs an O3-only analysis. This will serve as a template for how to run TGAS-only analysis ... we'll need to talk for the latter - I will put those changes in another PR, as I want for this one to go in first. |
This should be everything needed for the GEOSana_GridComp for full CoDAS functionality (M2CC, SCREAM products, etc.).