Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old CCMI resources from GMI #226

Merged
merged 3 commits into from
Nov 7, 2022
Merged

Remove old CCMI resources from GMI #226

merged 3 commits into from
Nov 7, 2022

Conversation

mmanyin
Copy link
Contributor

@mmanyin mmanyin commented Nov 4, 2022

This PR is zero-diff except for GMI. The option of using old resource files from REF-C1 and REF-C2 is now removed.

@mmanyin mmanyin added the 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Nov 4, 2022
@mmanyin mmanyin requested a review from a team as a code owner November 4, 2022 18:26
@mmanyin mmanyin requested a review from a team as a code owner November 4, 2022 21:32
tclune
tclune approved these changes Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bonus for pure deletion PR's!

mathomp4
mathomp4 approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@mathomp4 mathomp4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trust in Mike!

@mmanyin mmanyin merged commit 2180f2c into develop Nov 7, 2022
@mmanyin mmanyin deleted the feature/mmanyin/rm_old_ccmi_resources branch November 7, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

@tclune tclune tclune approved these changes

Assignees
No one assigned
Labels
0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmanyin @mathomp4 @tclune