Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/vvalenti/gcr emissions fix #227

Merged
merged 4 commits into from
Nov 7, 2022

Conversation

vlvalenti
Copy link
Contributor

Fixing 1d vector of latitude degrees declared and used in GCR emissions
zero diff for pchem simulations.
non-zero diff for gmi simulations, unless do_gcr is set to False.

@vlvalenti vlvalenti requested a review from a team as a code owner November 4, 2022 23:01
@vlvalenti vlvalenti added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Nov 4, 2022
Copy link
Contributor

@mmanyin mmanyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this fix is good

@mmanyin mmanyin merged commit f1bed09 into develop Nov 7, 2022
@mmanyin mmanyin deleted the feature/vvalenti/GCR_emissions_fix branch November 7, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants