Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GMI issue related to stOX_loss #235

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

mmanyin
Copy link
Contributor

@mmanyin mmanyin commented Dec 5, 2022

TR now imports stOX_loss only as needed. This addresses an assumption in GMI; without the fix, GMI would exit the program when stOX was not running and pr_qqjk was FALSE.
The "loss species" string of stOX has now been changed from "O3" to "OX", just for clarity.

@mmanyin mmanyin added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Dec 5, 2022
@mmanyin mmanyin requested a review from a team as a code owner December 5, 2022 15:42
@mmanyin mmanyin merged commit 6b625dd into develop Dec 5, 2022
@mmanyin mmanyin deleted the feature/mmanyin/TR_stox_refinement branch December 5, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants