Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up lbssad_opt and h2oclim_opt #236

Merged
merged 5 commits into from
Dec 16, 2022

Conversation

ssteenro
Copy link
Contributor

@ssteenro ssteenro commented Dec 8, 2022

Cleaned up lbssad_opt (1 or 3) and took out h2oclim_opt (only 3 worked) and eliminated "ldynvar" which was never used here

@ssteenro ssteenro requested a review from a team as a code owner December 8, 2022 20:59
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

@ssteenro ssteenro added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Dec 8, 2022
Copy link
Contributor

@mmanyin mmanyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is zero diff for all cases -- approve.

@mmanyin mmanyin merged commit b69c4f9 into develop Dec 16, 2022
@mmanyin mmanyin deleted the feature/ssteenro/lbssad_h2oclim_opt_cleanup branch December 16, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants