Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split out TR, GMI, and StratChem #243

Merged
merged 7 commits into from
Jan 18, 2023
Merged

Split out TR, GMI, and StratChem #243

merged 7 commits into from
Jan 18, 2023

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Jan 17, 2023 •
edited
Loading

This is a companion PR to GEOS-ESM/GEOSgcm#509

It removes TR, GMI, and StratChem to make them separate repos.

NOTE: CI will never succeed due to chicken-and-egg. GEOSgcm needs split repos, but it can't use the split repos until this change/tag is in GEOSgcm.

@mathomp4 mathomp4 added the 0 diff structural Structural changes to repository that are zero-diff label Jan 17, 2023
@mathomp4 mathomp4 self-assigned this Jan 17, 2023
@mmanyin mmanyin marked this pull request as ready for review January 18, 2023 16:24
@mmanyin mmanyin requested review from a team as code owners January 18, 2023 16:24
mmanyin
mmanyin approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@mmanyin mmanyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I demonstrated zero-diff for GMI, StratChem and TR as of Jan 9, and no changes of substance have been made since then. Thanks @mathomp4 !

@mathomp4 mathomp4 changed the title WIP: Split out TR, GMI, and StratChem Split out TR, GMI, and StratChem Jan 18, 2023
@mathomp4 mathomp4 merged commit d0e0ccd into develop Jan 18, 2023
@mathomp4 mathomp4 deleted the feature/mathomp4/split-gmi-sc-tr branch January 18, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmanyin mmanyin mmanyin approved these changes

Assignees

@mathomp4 mathomp4

Labels
0 diff structural Structural changes to repository that are zero-diff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathomp4 @mmanyin