Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for GMI/GOCART2G coupling; new wrapper for MAPL SZA #259

Merged
merged 19 commits into from
Apr 24, 2023
Merged

Add support for GMI/GOCART2G coupling; new wrapper for MAPL SZA #259

merged 19 commits into from
Apr 24, 2023

Conversation

mmanyin
Copy link
Contributor

@mmanyin mmanyin commented Apr 24, 2023

This PR is zero-diff for PCHEM experiments.
It extends capability for GMI and GEOS-Chem.
It also fixes a problem with parallel reads on the Lustre filesystem at NAS.

Details:

  • Added connectivity from GOCART2G aerosols to GMI chem
  • Added CO2 connectivity in GEOS_ChemGridComp for GOCART-GEOS-Chem coupling
  • Added a wrapper routine for the MAPL Solar Zenith Angle call, in Chem_Shared
  • Removed the routines (originally from GMI) which computed Solar Zenith Angle, in Chem_Shared; but in a later commit, this was added back temporarily, so that older versions of GMI and TR don't complain.
  • Removed parallel read of PChem species file. This parallel read was causing issues at NAS at large node count, so now we just do a read-on-root followed by a broadcast
  • Fixed a bug that had prevented GMI running with HEMCO

Christoph Keller and others added 19 commits February 8, 2023 12:37
Added CO2 connectivity between GOCART and GEOS-Chem
196702d
Merge branch 'develop' into feature/cakelle2/CO2coupling_GOCART_GCC
0824213
@mmanyin
Merge branch 'develop' into feature/cakelle2/CO2coupling_GOCART_GCC
3203412
Update CHANGELOG.md
101885d
@mmanyin
Merge pull request #247 from GEOS-ESM/feature/cakelle2/CO2coupling_GO…
2571bd3 
…CART_GCC

Add CO2 connectivity between GOCART and GEOS-Chem
@mmanyin
Swapped out the GMI routines (in Chem_Shared) for SZA, and replaced w…
7851cba 
…ith a wrapper to the MAPL call
Add connectivity between GOCART2G aerosols and GMI chem
3ce725c
update changelog
c43bc67
@mmanyin
Merge pull request #255 from GEOS-ESM/feature/mmanyin/use_MAPL_SZA
2b08269 
Use solar zenith angle from MAPL
@mmanyin
Added back the GmiSolar routines, until TR and GMI releases are done
89c7ed8
@mmanyin
Merge pull request #256 from GEOS-ESM/feature/mmanyin/temporarily_res…
0d41f23 
…tore_gmi_solar_routines

temporarily restore the GmiSolar routines
@mathomp4
Use serial read for PChem species file
93cc940
@mathomp4
Completely remove parallel read
0062625
@mmanyin
Merge pull request #257 from GEOS-ESM/feature/mathomp4/serial-pchem-d…
40da687 
…evelop

Use serial read for PChem species file
update to use AERO BUNDLE instead of importing G2G components
690bf5b
@vlvalenti
Merge branch 'develop' into feature/vvalenti/gocart2g_to_gmi_connecti…
cfeb2ba 
…vity
@mmanyin
Merge pull request #254 from GEOS-ESM/feature/vvalenti/gocart2g_to_gm…
a06b023 
…i_connectivity

Feature/vvalenti/gocart2g to gmi connectivity
@mmanyin
Updated CHANGELOG ahead of next release.
3f02d54
@mmanyin
Merge pull request #258 from GEOS-ESM/feature/mmanyin/edit_CHANGELOG_…
3e6664a 
…2023_04_24

Updated CHANGELOG ahead of next release.
@mmanyin mmanyin added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Apr 24, 2023
@mmanyin mmanyin requested review from a team as code owners April 24, 2023 14:43
@mmanyin mmanyin merged commit 5a15f90 into main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

Assignees
No one assigned
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmanyin @mathomp4 @vlvalenti