-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving GOCART legacy to be sourced from GOCART repository. #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamJamieson
added
the
Contingent - DNA
These changes are contingent on other PRs
label
Feb 23, 2021
Update to the release tag of GOCART-legacy.
WilliamJamieson
added
the
0 diff
The changes in this pull request have verified to be zero-diff with the target branch.
label
Feb 24, 2021
Note to @gmao-esherman (just in case he didn't know) that in this PR, GOCART2G is sparsed away, so in your work on 2G, you'll need to...un-sparse. |
Noted, thanks. |
mathomp4
approved these changes
Mar 17, 2021
gmao-esherman
approved these changes
Mar 17, 2021
mathomp4
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0 diff
The changes in this pull request have verified to be zero-diff with the target branch.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a multi-repository pull request to move GOCART legacy's source code from the
GEOSchem_GridComp
repository to theGOCART
repository. All of the GOCART code remain's untouched, aside from moving it to a slightly different directory location and accompanying cmake changes.The related pull request is #115 in the
GEOSchem_GridComp
repository. Note that once theGEOSchem_GridComp
PR has been accepted, the components.yaml file of this PR will need to be updated to new tag of theGEOSchem_GridComp
.I have tested this change by running a C12 experiment for 1 day and have found the results to be zero diff.