Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving GOCART legacy to be sourced from GOCART repository. #257

Merged
merged 12 commits into from
Mar 17, 2021

Conversation

WilliamJamieson
Copy link
Contributor

This is part of a multi-repository pull request to move GOCART legacy's source code from the GEOSchem_GridComp repository to the GOCART repository. All of the GOCART code remain's untouched, aside from moving it to a slightly different directory location and accompanying cmake changes.

The related pull request is #115 in the GEOSchem_GridComp repository. Note that once the GEOSchem_GridComp PR has been accepted, the components.yaml file of this PR will need to be updated to new tag of the GEOSchem_GridComp.

I have tested this change by running a C12 experiment for 1 day and have found the results to be zero diff.

Update to the release tag of GOCART-legacy.
@WilliamJamieson WilliamJamieson added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Feb 24, 2021
@mathomp4
Copy link
Member

Note to @gmao-esherman (just in case he didn't know) that in this PR, GOCART2G is sparsed away, so in your work on 2G, you'll need to...un-sparse.

@gmao-esherman
Copy link

Note to @gmao-esherman (just in case he didn't know) that in this PR, GOCART2G is sparsed away, so in your work on 2G, you'll need to...un-sparse.

Noted, thanks.

@mathomp4 mathomp4 self-requested a review March 17, 2021 20:26
@mathomp4 mathomp4 removed the Contingent - DNA These changes are contingent on other PRs label Mar 17, 2021
@sdrabenh sdrabenh merged commit 45955e2 into main Mar 17, 2021
@sdrabenh sdrabenh deleted the feature/wjamieson/GOCART_legacy_changes branch March 17, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants