Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Baselibs 7.24.0 and MAPL 2.46.1 for Spack Build support #750

Merged
merged 18 commits into from
May 15, 2024

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Feb 13, 2024

This is a companion to:

where we are trying to get the ESMF::ESMF target working for Spack builds.

This has the following updates:

  1. Update to ESMA_env v4.29.0 → Baselibs 7.24.0 (ESMF 8.6.1b04)
  2. Update to MAPL 2.46.1 → (Many updates from MAPL 2.45, update FindESMF.cmake for spack)

In Baselibs-style GEOSgcm runs, this is zero-diff in all testing.

@mathomp4 mathomp4 added the 0 diff structural Structural changes to repository that are zero-diff label Feb 13, 2024
@mathomp4 mathomp4 self-assigned this Feb 13, 2024
@mathomp4 mathomp4 changed the title Use ESMF::ESMF as the main target from FindESMF.cmake for non-Baselibs Updates for Spack Builds Apr 25, 2024
@mathomp4 mathomp4 changed the title Updates for Spack Builds Update to Baselibs 7.24.0 and MAPL 2.46 for Spack Build support Apr 25, 2024
@mathomp4 mathomp4 added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. and removed 0 diff structural Structural changes to repository that are zero-diff labels Apr 25, 2024
@mathomp4
Copy link
Member Author

Craaaaap! Why is CI unhappy?!

@mathomp4 mathomp4 marked this pull request as ready for review May 2, 2024 18:48
@mathomp4 mathomp4 requested review from a team as code owners May 2, 2024 18:48
@mathomp4 mathomp4 changed the title Update to Baselibs 7.24.0 and MAPL 2.46 for Spack Build support Update to Baselibs 7.24.0 and MAPL 2.46.1 for Spack Build support May 10, 2024
@sdrabenh sdrabenh merged commit 30f4a9c into main May 15, 2024
13 checks passed
@sdrabenh sdrabenh deleted the hotfix/mathomp4/fix-spack-build branch May 15, 2024 18:20
@climbfuji
Copy link

Thanks!

There will need to be a follow-up PR for the ESMA_cmake update in GEOS-ESM/ESMA_cmake#377. After that, we need to retest one last time (knock on wood) with JEDI and hopefully we can put a tag on GEOSgcm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants