Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After talking with @dr0cloud about how to get RRTMGP to work with GOCART2G, I realized that some of the lines in
AGCM.rc.tmpl
are now superfluous. The Mie optics tables are now handled inside of GOCART and they aren't read throughAGCM.rc
. So, we can remove them.Note that enabling RRTMGP now requires both modifying
AGCM.rc
in an experiment as well as changing the GOCART instance rc files. Something like this:can do it. This probably indicates that when multiple people start testing RRTMGP, we'll want to add a question to
gcm_setup
to add this code automatically (as well as transformAGCM.rc.tmpl
in the right way.ETA: I've pushed changes to gcm_run, gcm_regress, and gcm_forecast with this:
so that @dr0cloud or anyone that wants to run RRTMGP can just comment out these lines. Not perfect, but will let people not have to remember.