-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HISTORY for coupled model applications #359
Update HISTORY for coupled model applications #359
Conversation
…anges for MOM5 coupled model history.
Putting a blocker on this until I can fix the bug in gcm_setup...plus I want to tweak it a bit anyway. :) |
@mathomp4 is there an issue that explains what the "bug" is about? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like these changes! Thank you @mathomp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense!
I tested @mathomp4's addition(s): set up dummy exps (for MOM5 and MOM6), not with Works well, the |
The CI is still unhappy. need to figure out why... |
Okay. I know why. I need to update the docker images because this change breaks my create_expt.py script without a few fixes. Time to fix it! |
Fingers crossed. I think this should work now. |
Okay. Now I think it should work. Feeling dumb today! |
Yay! Took a few tries, but it worked! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that indentation!
This PR:
HISTORY.AOGCM-MOM5.rc.tmpl
to be used if the ocean model isMOM5
(this file originates from previous versions of https://github.com/GEOS-ESM/GEOSgcm_App/ what was calledHISTORY.AOGCM.rc.tmpl
).MOM6
,HISTORY.AOGCM.rc.tmpl
has been made from HISTORY.AGCM.rc.tmpl, by simply addingocean
andsea ice
collections. (@zhaobin74, thanks for the sea ice bits.)Thank you @sdrabenh for the above suggestions.
gcm_setup
section for choice ofHISTORY.rc
, NOW clearly states what should be used when theocean model
==MOM5
.Both of the above HISTORY.rc files write monthly files and anything more frequent has been kept to the absolute least.