-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update path for M2_REPLAY_ANA_LOCATION #377
Conversation
@rlucches, this is precisely what this PR updates our scripts to use. And I have tested to make sure it works. Thanks! |
AGCM.rc.tmpl
Outdated
@@ -273,7 +273,7 @@ RECORD_REF_TIME: >>>REFTIME<<< >>>FCSTIME<<< | |||
#M2 REPLAY_ANA_EXPID: MERRA-2 | |||
#M2 REPLAY_ANA_LOCATION: @M2_REPLAY_ANA_LOCATION | |||
#M2 REPLAY_MODE: Regular | |||
#M2 REPLAY_FILE: ana/Y%y4/M%m2/MERRA-2.ana.eta.%y4%m2%d2_%h2z.nc4 | |||
#M2 REPLAY_FILE: /discover/nobackup/projects/gmao/merra2/data/ana/MERRA2_all/Y%y4/M%m2/MERRA2.ana.eta.%y4%m2%d2_%h2z.nc4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sanAkel I'm not sure this needs to be a full path. I want to say the model uses REPLAY_ANA_LOCATION
to prepend to REPLAY_FILE
. So this probably should only be...uh...maybe:
#M2 REPLAY_FILE Y%y4/M%m2/MERRA2.ana.eta.%y4%m2%d2
Dunno. Probably needs testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: It's done this way because the files are in a different place at NAS...and I now realize we probably need to do something at NAS for this. I'll talk with @bena-nasa ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mathomp4 The "prepend" did not work for me. I tested withOUT full path (in REPLAY_FILE
) and at runtime it was looking for files like: Y%y4/M%m2/MERRA2.ana.eta.%y4%m2%d2_%h2z.nc4
. My test was at NCCS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sanAkel Hmm. Well need to to figure it out otherwise we break Replay at NAS. I'll try and see if I can figure it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mathomp4 line 2641
of /discover/nobackup/sakella/test1/slurm-66111020.out
may help!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. I think it's done and seems to work. Apparently we need REPLAY_FILE
to start with ana/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. And I pushed the changes. Give them a try when you can.
I've added a blocker label until @bena-nasa and I can fix up the files at NAS to work with this new location paradigm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mathomp4 I tried, it works with your changes.
All the data should be in the new place at NAS with symlinks in the place the data was sitting so as to not break any backwards compatibility with older tags |
Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: enhancement, bugfix, 0 diff, Contingent - DNA |
Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: enhancement, bugfix, 0 diff, Contingent - DNA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approve!
This PR updates:
AGCM.rc.tmpl
The reason for this update is because the current:
M2_REPLAY_ANA_LOCATION
➡️/discover/nobackup/projects/gmao/share/gmao_ops/verification/MERRA-2/ana/
which only goes up toY2021/M01
. The files are NOT up to date.Per @rlucches (via @danholdaway), a good alternative that is kept current is:
/discover/nobackup/projects/gmao/merra2/data/ana/MERRA2_all
which is what this PR provides.This update has been tested.