Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/yury/aogcm notilehist regrid_exch: tile_hist.data was removed from history template #383

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

yvikhlya
Copy link

@yvikhlya yvikhlya commented Dec 8, 2022

... for tripolar collections in previous PR and this PR removes linking tile_hist.data in gcm_run.j script, since it is not necessary anymore. Interpolation of tripolar output to latlon grid is done with grid_label option. Perhaps, regrid_exch option should be removed from MAPL too, but I am not sure about this.

history diagnostics from tripolar to latlon grid.
@yvikhlya yvikhlya requested a review from a team as a code owner December 8, 2022 17:56
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

@yvikhlya yvikhlya requested review from sanAkel and zhaobin74 December 8, 2022 17:57
@yvikhlya yvikhlya self-assigned this Dec 8, 2022
@yvikhlya yvikhlya added enhancement New feature or request 0 diff structural Structural changes to repository that are zero-diff labels Dec 8, 2022
@mathomp4
Copy link
Member

I'm going to invoke @bena-nasa to see if maybe regrid_exch is just dead code in MAPL now. Always good to remove unneeded code!

@sdrabenh sdrabenh merged commit 6ee59a0 into develop Dec 14, 2022
@sdrabenh sdrabenh deleted the bugfix/yury/aogcm-notilehist branch December 14, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff structural Structural changes to repository that are zero-diff enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants