Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Rome detection at NAS, fixes for AWS and unknown #460

Merged
merged 5 commits into from
May 18, 2023
Merged

Remove Rome detection at NAS, fixes for AWS and unknown #460

merged 5 commits into from
May 18, 2023

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented May 16, 2023 •
edited
Loading

With NAS moving to all nodes using TOSS4, we remove the use of the detection.

Also, we try and detect number of cores on unknown systems (desktops) as well as add some bits for AWS/Azure to make a user edit the setup script before an experiment can run.

This PR is in concert with:

@mathomp4 mathomp4 added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs labels May 16, 2023
@mathomp4 mathomp4 self-assigned this May 16, 2023
@mathomp4 mathomp4 mentioned this pull request May 16, 2023
Merged
@github-actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA

2 similar comments
@github-actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA

@github-actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA

@github-actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA

@github-actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA

@mathomp4
Merge branch 'develop' into feature/mathomp4/nas-all-toss4
a0b7031 
# Conflicts:
#	gcm_setup
#	geoschemchem_setup
#	gmichem_setup
#	stratchem_setup
@github-actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA

This was referenced May 18, 2023
Merged
Merged
@mathomp4 mathomp4 marked this pull request as ready for review May 18, 2023 14:16
@mathomp4 mathomp4 requested a review from a team as a code owner May 18, 2023 14:16
@github-actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA

@sdrabenh sdrabenh removed the Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label May 18, 2023
@sdrabenh sdrabenh merged commit f60e9ee into develop May 18, 2023
@sdrabenh sdrabenh deleted the feature/mathomp4/nas-all-toss4 branch May 18, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdrabenh sdrabenh sdrabenh approved these changes

Assignees

@mathomp4 mathomp4

Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathomp4 @sdrabenh