Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new SCM file dir #477

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Update to new SCM file dir #477

merged 3 commits into from
Jun 21, 2023

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Jun 15, 2023

The updates in v11 require fixes to sedfiles in the scminfiles. This PR brings them in.

NOTE: This PR in in combination with GEOS-ESM/GEOSgcm_GridComp#725 The SCM will not run without that.

ETA: Per @narnold1, this only lets things work at L72. I have an idea on how to fix L137, but probably need the expertise of @bena-nasa to test. For now I'll keep this still mergable as it at least fixes part of the SCM.

@mathomp4 mathomp4 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Jun 15, 2023
@mathomp4 mathomp4 requested a review from a team as a code owner June 15, 2023 18:45
@mathomp4 mathomp4 self-assigned this Jun 15, 2023
@sdrabenh sdrabenh merged commit 43a3d4c into develop Jun 21, 2023
@sdrabenh sdrabenh deleted the bugfix/mathomp4/scm-fixes branch June 21, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants