Use nccmp, add readers/writers test to regress #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathomp4
added
the
0 diff
|
Welp, it seems to work for me. Undrafting. |
sdrabenh
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #571
Closes #572
This PR moves
gcm_regress.jto usenccmpinstead ofcmpfor comparison of restarts (non-MOM).It also changes
NUM_READERSandNUM_WRITERSto 6 for the 1x6 layout test as a test of that.NOTE: We move to use
nccmpas it was found that there seem to be differences in the HDF5 Superblock when written with multiple writers. The data and metadata is all the same, but something changes and then, boom, different files technically such thatcmpwill not work.