add definition of land constants collection into HISTORY.rc.tmpl #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmao-rreichle
added
enhancement
gmao-rreichle
added a commit
that referenced
this pull request
Aug 5, 2024
…l (as in GEOSgcm_App PR #636 but for R21C)
|
@biljanaorescanin, @sdrabenh: I'm marking this "ready for review", even though it still requires some work. So far, the changes needed for the land constants HISTORY have only been made in the standard HISTORY template. Other HISTORY templates may still need matching updates, but I'm not the one to decide. |
biljanaorescanin
removed
the
Contingent - DNA
biljanaorescanin
approved these changes
Aug 28, 2024
|
@sdrabenh we are ready with this PR since if someone needs these files for their History they can just pick it up from here. Not sure do we need to comment collections out or leave it like this. I don't know what is the practice with adding collections. |
sdrabenh
approved these changes
Sep 13, 2024
Best to leave new collections commented out as they are here. If the user wants to turn them on, they can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses GEOS-ESM/GEOSgcm_GridComp#968
Contingent on: GEOS-ESM/GEOSgcm_GridComp#970
For now, changes are reflected only in the standard HISTORY template. Other HISTORY files need to be updated as appropriate. New "land constants" collection is turned off by default.