Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove executables on tmpdir #644

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented Sep 5, 2024

Even the TMPDIR is set by users, if g5_modules is sourced in a terminal, the TMPDIR would be reset by openmpi to /tmp where is not allowed to execute a file. So gcm_setup would work without source g5_modules but fail after source g5_modules.

@weiyuan-jiang weiyuan-jiang added bugfix This pull request fixes a bug 0 diff The changes in this pull request have verified to be zero-diff with the target branch. labels Sep 5, 2024
@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner September 5, 2024 13:45
@weiyuan-jiang
Copy link
Contributor Author

This PR address issue #642

@mathomp4
Copy link
Member

mathomp4 commented Sep 5, 2024

@sdrabenh We might just want to keep this in gcm_setup only. I took a look and the corresponding code blocks in the other _setup scripts are...confusing. Hopefully when we extend the Python setup from @sshakoor1 to the other chemistries, we can do this better.

@mathomp4
Copy link
Member

I can say this works for me...or well, didn't change the resulting experiment!

@sdrabenh sdrabenh merged commit 9ef8419 into develop Sep 13, 2024
4 of 6 checks passed
@sdrabenh sdrabenh deleted the bugfix/wjiang/tmpdir_execute branch September 13, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix This pull request fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants