Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update land-related collections in HISTORY.rc.tmpl to match M21C file specs #663

Merged

Conversation

gmao-rreichle
Copy link
Contributor

The primary objective of the present PR is to bring the file specs changes from M21C into "develop". The corresponding (although somewhat outdated) M21C PR is #356 (merged on 8 Dec 2022).

Labeled as 0-diff under the assumption that tests have their own HISTORY.rc files.

These changes still need to be propagated into the custom HISTORY.rc templates to be reflected in GEOS products. The key target is FP. For FP, however, the file specs change has to be mid-stream, which creates its own complications. Nevertheless, it is critical that FP be updated sooner rather than later. The changes implemented in this PR and the related PR below include bug fixes (in land budget variable meaning) and improved user friendliness of several land-related variable shortnames and longnames.

Related PRs:
GEOS-ESM/GEOSgcm_GridComp#1032

cc: @rgelaro @rlucches @sdrabenh @biljanaorescanin

@gmao-rreichle gmao-rreichle added documentation Improvements or additions to documentation bugfix This pull request fixes a bug 0 diff The changes in this pull request have verified to be zero-diff with the target branch. labels Nov 12, 2024
@gmao-rreichle gmao-rreichle requested a review from a team as a code owner November 12, 2024 21:53
@mathomp4
Copy link
Member

I can never remember. Does FP use HISTORY.rc.tmpl or the ones with hours like HISTORY_FP.rc.03z.tmpl?

@gmao-rreichle
Copy link
Contributor Author

I can never remember. Does FP use HISTORY.rc.tmpl or the ones with hours like HISTORY_FP.rc.03z.tmpl?

As far as I know, HISTORY.rc.tmpl is just the generic template that's not really used by anything. I'm not sure which HISTORY templates are used by FP, and I would be surprised if they're not coming in from some other repo (likely somewhere in the ADAS). In any case, all I can do is to update the generic template. Rob and the ADAS team will have to work these updates into the FP tag when they're ready for the changes to take effect.

@rlucches
Copy link

rlucches commented Nov 14, 2024

I can never remember. Does FP use HISTORY.rc.tmpl or the ones with hours like HISTORY_FP.rc.03z.tmpl?

FP uses the HISTORY.rc files with the time stamps included. The HISTORY changes depending on which cycle is being run due to the differences in the forecast lengths and the implementation of the FSOI.

Note mid-stream changes to HISTORY in FP are typically avoided and the best choice would be to include this as part of the major overhaul that will come next year when the resolution changes. If it must get in sooner, I will have to review the impact on the file spec to notify users. The product involved may have to be dropped from the OpenDAP time series as well.

@mathomp4
Copy link
Member

Learned something new. Okay, so HISTORY.rc.tmpl is sort of a "Ops-like" HISTORY but not the "real" history used.

So maybe eventually the changes from @gmao-rreichle here can be ported over to the timestamp-histories when @rlucches, et al are ready.

@gmao-rreichle
Copy link
Contributor Author

mid-stream changes to HISTORY in FP are typically avoided and the best choice would be to include this as part of the major overhaul that will come next year when the resolution changes.

@rlucches @sdrabenh : I was thinking of this taking effect in FP when the vertical resolution is increased (ie, when the "v12" GCM is adopted in the ADAS). I was calling this a "mid-stream" change because FP never really stops, but that's just semantics. In any case, there isn't a better opportunity for tinkering with the file specs that I can foresee. Since the PR is going into the develop branch, there should be no harm in merging the PR now. @sdrabenh would have to make sure that develop and @wmputman's "v12" branch are synced appropriately.

@rlucches: would it make sense to apply the same changes to the HISTORY_FP.rc.[hh]z.tmpl before merging the PR? Or should we leave this for when the "v12" GCM is integrated into the ADAS?

@sdrabenh: Do we want to update any of the other HISTORY tmpl files before merging the PR?

@sdrabenh sdrabenh merged commit 6901c19 into develop Dec 5, 2024
19 checks passed
@sdrabenh sdrabenh deleted the feature/rreichle/update_exports_to_M21C_filespecs branch December 5, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix This pull request fixes a bug documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants