-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update land-related collections in HISTORY.rc.tmpl to match M21C file specs #663
update land-related collections in HISTORY.rc.tmpl to match M21C file specs #663
Conversation
I can never remember. Does FP use |
As far as I know, |
FP uses the HISTORY.rc files with the time stamps included. The HISTORY changes depending on which cycle is being run due to the differences in the forecast lengths and the implementation of the FSOI. Note mid-stream changes to HISTORY in FP are typically avoided and the best choice would be to include this as part of the major overhaul that will come next year when the resolution changes. If it must get in sooner, I will have to review the impact on the file spec to notify users. The product involved may have to be dropped from the OpenDAP time series as well. |
Learned something new. Okay, so So maybe eventually the changes from @gmao-rreichle here can be ported over to the timestamp-histories when @rlucches, et al are ready. |
@rlucches @sdrabenh : I was thinking of this taking effect in FP when the vertical resolution is increased (ie, when the "v12" GCM is adopted in the ADAS). I was calling this a "mid-stream" change because FP never really stops, but that's just semantics. In any case, there isn't a better opportunity for tinkering with the file specs that I can foresee. Since the PR is going into the develop branch, there should be no harm in merging the PR now. @sdrabenh would have to make sure that develop and @wmputman's "v12" branch are synced appropriately. @rlucches: would it make sense to apply the same changes to the @sdrabenh: Do we want to update any of the other HISTORY tmpl files before merging the PR? |
The primary objective of the present PR is to bring the file specs changes from M21C into "develop". The corresponding (although somewhat outdated) M21C PR is #356 (merged on 8 Dec 2022).
Labeled as 0-diff under the assumption that tests have their own HISTORY.rc files.
These changes still need to be propagated into the custom HISTORY.rc templates to be reflected in GEOS products. The key target is FP. For FP, however, the file specs change has to be mid-stream, which creates its own complications. Nevertheless, it is critical that FP be updated sooner rather than later. The changes implemented in this PR and the related PR below include bug fixes (in land budget variable meaning) and improved user friendliness of several land-related variable shortnames and longnames.
Related PRs:
GEOS-ESM/GEOSgcm_GridComp#1032
cc: @rgelaro @rlucches @sdrabenh @biljanaorescanin