-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructuring under GEOSocean_GridComp #447
Labels
0 diff structural
Structural changes to repository that are zero-diff
Comments
yvikhlya
added
the
0 diff structural
Structural changes to repository that are zero-diff
label
Jul 29, 2021
I know something like this has been on @sanAkel 's mind. Maybe he's done some work? |
@yvikhlya For example:
If possible, orphan points as well ... Like we have for OBIO related functionality. This will make it better readable. Thanks! |
This was referenced Jul 30, 2021
Given |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This was planned since a while ago, but I can't find a related opened issue. Currently, under
GEOSocean_GridComp
directory, we don't haveGEOS_OceanGridComp.F90
component. Instead, we haveGuestOcean_GridComp
andGEOSdatasea_GridComp
, which is actually a child ofGuestOcean_GridComp
. This is inconsistent with GEOS conventions for nesting components. To resolve this inconsistency, the following is proposed:GEOSocean_GridComp/GEOS_OceanGridComp.F90
component.GuestOcean_GridComp/GuestOcean_GridComp.F90
intoGEOS_OceanGridComp.F90
.GEOSdatasea_GridComp
,MOM_GEOS5PlugMod
andMOM6_GEOSPlug
to be children ofGEOS_OceanGridComp.F90
.GuestOcean_GridComp
.These are structural zero-diff changes. We may need help from SIteam to make
CMakeLists
correct.The text was updated successfully, but these errors were encountered: