Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructuring under GEOSocean_GridComp #447

Closed
yvikhlya opened this issue Jul 29, 2021 · 5 comments
Closed

Restructuring under GEOSocean_GridComp #447

yvikhlya opened this issue Jul 29, 2021 · 5 comments
Assignees
Labels
0 diff structural Structural changes to repository that are zero-diff

Comments

@yvikhlya
Copy link

yvikhlya commented Jul 29, 2021

This was planned since a while ago, but I can't find a related opened issue. Currently, under GEOSocean_GridComp directory, we don't have GEOS_OceanGridComp.F90 component. Instead, we have GuestOcean_GridComp and GEOSdatasea_GridComp, which is actually a child of GuestOcean_GridComp. This is inconsistent with GEOS conventions for nesting components. To resolve this inconsistency, the following is proposed:

  • Create GEOSocean_GridComp/GEOS_OceanGridComp.F90 component.
  • Move functionality of GuestOcean_GridComp/GuestOcean_GridComp.F90 into GEOS_OceanGridComp.F90.
  • Make GEOSdatasea_GridComp, MOM_GEOS5PlugMod and MOM6_GEOSPlug to be children of GEOS_OceanGridComp.F90.
  • Delete GuestOcean_GridComp.
    These are structural zero-diff changes. We may need help from SIteam to make CMakeLists correct.
@yvikhlya yvikhlya added the 0 diff structural Structural changes to repository that are zero-diff label Jul 29, 2021
@yvikhlya yvikhlya self-assigned this Jul 29, 2021
@mathomp4
Copy link
Member

I know something like this has been on @sanAkel 's mind. Maybe he's done some work?

@sanAkel
Copy link
Contributor

sanAkel commented Jul 29, 2021

I know something like this has been on @sanAkel 's mind. Maybe he's done some work?

yes, indeed!
@yvikhlya when I am back from break, will do a PR to address this issue. Thanks!

@yvikhlya
Copy link
Author

I know something like this has been on @sanAkel 's mind. Maybe he's done some work?

yes, indeed!
@yvikhlya when I am back from break, will do a PR to address this issue. Thanks!

No worries. I already have it almost done. I'll push a branch shortly.

@sanAkel
Copy link
Contributor

sanAkel commented Jul 30, 2021

@yvikhlya
Could you also please move all things related to dual ocean into a subroutine within the GC?

For example:

  • init_dualOcean()
    _ run_dualOcean()
    Etc

If possible, orphan points as well ...

Like we have for OBIO related functionality. This will make it better readable. Thanks!

@sanAkel
Copy link
Contributor

sanAkel commented Oct 13, 2021

Given ⤴️ merged PRs, this issue can be closed.

@sanAkel sanAkel closed this as completed Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff structural Structural changes to repository that are zero-diff
Projects
None yet
Development

No branches or pull requests

3 participants