-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructuring under GEOSocean_GridComp #448
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmake changes ok
Note: This will never pass CI here. It's a fun dependency issue, but the main thing is that by the time the CI system knows to checkout this branch, it's already done a So, I'll need to work with @sdrabenh when this goes in to turn off CI. |
Also note that I renamed GEOSocean_GridComp to GEOS_OceanGridComp. This way there is no need in "OVERRIDE" statement in CmakeLists. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as superuser.
This PR addresses #447 and is contingent on GEOS-ESM/GEOSgcm#317.