Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send clear message to log when mk_lakelandicesaltwater failed #1006

Merged
merged 2 commits into from
Sep 28, 2024

Conversation

weiyuan-jiang
Copy link
Contributor

When restart file does not match the tile file, the program crashes. But without clear message, it is hard to figure out why it crashes. This PR would send the message to the log file.

@weiyuan-jiang weiyuan-jiang added the 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Sep 20, 2024
@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner September 20, 2024 13:27
@weiyuan-jiang
Copy link
Contributor Author

If the tile number of restart file is greater than that of the tile file, the program would run successfully. That is even worse.

@gmao-rreichle
Copy link
Contributor

If the tile number of restart file is greater than that of the tile file, the program would run successfully. That is even worse.

@weiyuan-jiang, I guess by "run successfully" you mean that the program runs but produces garbage? In any case, are you suggesting that we also make this a hotfix? Merging it into develop is obviously needed but would not fix the issue in tagged versions of the model.

cc: @biljanaorescanin @sdrabenh

@weiyuan-jiang
Copy link
Contributor Author

If the tile number of restart file is greater than that of the tile file, the program would run successfully. That is even worse.

@weiyuan-jiang, I guess by "run successfully" you mean that the program runs but produces garbage? In any case, are you suggesting that we also make this a hotfix? Merging it into develop is obviously needed but would not fix the issue in tagged versions of the model.

cc: @biljanaorescanin @sdrabenh

Yes, that is what I mean. I don't think we need a hot fix. If the users provide right restarts and BCs, everything should be right.

@sdrabenh sdrabenh merged commit 5210f4f into develop Sep 28, 2024
9 checks passed
@sdrabenh sdrabenh deleted the feature/wjiang/clear_message branch September 28, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants