Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/mfmehari/data atm bug fix #1015

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Feature/mfmehari/data atm bug fix #1015

merged 4 commits into from
Oct 29, 2024

Conversation

mfmehari
Copy link
Contributor

@mfmehari mfmehari commented Oct 3, 2024

A bug, that was making DataAtm to run with a certain number of processors but not with other numbers, has been fixed.
An update in GCM GC that allows DataAtm to run.
An ExtData yaml file has been added to the DataAtm GC directory.
A zero diff PR.

@mfmehari mfmehari added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Oct 3, 2024
@mfmehari mfmehari requested review from a team as code owners October 3, 2024 21:59
@sdrabenh
Copy link
Collaborator

@mfmehari just I tested this PR + GEOS-ESM/GEOSgcm_App#650 and the model crashes during initialization:

pe=00012 FAIL at line=00075 ExtDataConfig.F90 <could not find: CORE_NYF_Data_AtmForcings_ExtData.yaml>
pe=00012 FAIL at line=00084 ExtDataConfig.F90 <status=1>
pe=00012 FAIL at line=00051 ExtDataOldTypesCreator.F90 <status=1>
pe=00012 FAIL at line=00291 ExtDataGridCompNG.F90 <status=1>

The file exists in the source directory:
src/Components/@GEOSgcm_GridComp/GEOSdataatm_GridComp/CORE_NYF_Data_AtmForcings_ExtData.yaml
but not in the install directory. Thus, is is not copied to the exp directory either. Please fix these PRs and retest from a clean build to ensure they run. Also, please verify everything is 0-diff/disabled by default.

@mathomp4
Copy link
Member

@mfmehari You'll need to add something like:

install(FILES CORE_NYF_Data_AtmForcings_ExtData.yaml DESTINATION etc)

to the CMakeLists.txt to install it.

@mfmehari
Copy link
Contributor Author

@mathomp4 thank you very much!
I was to ask you ...

@mfmehari mfmehari requested a review from a team as a code owner October 24, 2024 16:16
@mfmehari
Copy link
Contributor Author

mfmehari commented Oct 24, 2024 •
edited
Loading

@sdrabenh the PRs are fixed, instructions to install the .yaml file have been added to CMakeLists.txt.
Rerun from a clean build.
It is a 0 diff fix.
Thank you!

@mfmehari mfmehari added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. and removed 0 diff The changes in this pull request have verified to be zero-diff with the target branch. labels Oct 24, 2024
@sdrabenh sdrabenh merged commit fd538d5 into develop Oct 29, 2024
9 checks passed
@sdrabenh sdrabenh deleted the feature/mfmehari/DataAtm_bug_fix branch October 29, 2024 19:56
@mfmehari
Copy link
Contributor Author

@sdrabenh @mathomp4 @bena-nasa Thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdrabenh sdrabenh sdrabenh approved these changes

@bena-nasa bena-nasa bena-nasa approved these changes

@mathomp4 mathomp4 mathomp4 approved these changes

Assignees
No one assigned
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mfmehari @sdrabenh @mathomp4 @bena-nasa