Feature/rtodling/gcm 1 12 4 tskinice realfix #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtodling
added
0 diff structural
gmao-rreichle
approved these changes
Feb 18, 2022
|
fixes #544 |
sanAkel
approved these changes
Feb 18, 2022
|
please see: #544 |
sanAkel
reviewed
Feb 18, 2022
| LONG_NAME = 'snow_or_ice_surface_temperature',& | ||
| UNITS = 'C' ,& | ||
| UNITS = 'K' ,& |
There was a problem hiding this comment.
UNITS = 'K' is correct based on @rtodling 's fix.
There was a problem hiding this comment.
zhaobin74
reviewed
Feb 18, 2022
| elsewhere | ||
| ISTSFC = MAPL_UNDEF | ||
| TSKINICE = MAPL_UNDEF |
There was a problem hiding this comment.
Could I suggest this line be changed to
TSKINICE = MAPL_TICE-1.8
MAPL_TICE-1.8 is the default value when there is no sea ice.
This can be done as another PR.
sdrabenh
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are fixes for TSKINICE - which so far are coming out as zero.
These require a change in HISTORY for consistency.
All instances of TSKINI in history are aliased to TSKINICE ... with this fix all instances should simply request TSKINICE and forget a aliasing.
The changed HISTORY's are already committed, but in the GEOSgcm_App repo ... will try to see if no conflicts there and submit a PR.