-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to read ocean _data_ using ExtData
#562
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t can be fill via ExtData
… GEOS_OradBioGridComp/GEOS_OradBioGridComp.F90 hence using DO_OBIO and/or DO_ORAD logic is best to be kept out of this. Simply sticking to whether it is coupled to ocean or not; ocean biology is left to be _data_.
…ntroduce logic to switch between binary and ExtData (netcdf) format- defaulting to binary, so as to get SAME answers; for now, 3. fix indentation
…Forcing) as default - for now.
… data SSS feature will be via ExtData-ONLY. Default case sets SSS=30 as before to obtain SAME answers.
…used. @bena-nasa please check syntax for: MAPL_TerminateImport on line 786. Thank you!
…nary file, that is read by MAPL_ReadForcing
…nary file, that is read by MAPL_ReadForcing. Nullify pointers at declaration.
…ry data, replaced character strings with simpler logical variables.
sanAkel
added
enhancement
New feature or request
0 diff
The changes in this pull request have verified to be zero-diff with the target branch.
labels
Mar 11, 2022
bena-nasa
previously approved these changes
Mar 11, 2022
yvikhlya
previously approved these changes
Mar 11, 2022
@mathomp4 🙏 for the quick fix |
yvikhlya
approved these changes
Mar 17, 2022
@mathomp4 thanks! I don't know how you spot these things so easily |
yeah! Especially those spaces: " " 😮 |
sdrabenh
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0 diff
The changes in this pull request have verified to be zero-diff with the target branch.
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional capability to read in ocean boundary conditions:
ExtData
.ON
by setting:OCEAN_EXT_DATA:.TRUE
inAGCM.rc
, in which case the user is expected to provide an.rc
file with the correct format (see below for an example).Reg. input netcdf files:
coupled
configuration one needs to provide ocean color (KPAR) only (without usingOBIO
, withDO_OBIO=0
).uncoupled
configuration we need KPAR, SST and sea ice concentration.The changes in this PR are zero-diff in default mode (binary inputs), and for the netcdf inputs, the differences are within the expected range (accounting for differences in ExtData and MAP_ReadForcing, as per @bena-nasa). This was checked in:
Example
.rc
file: