Fixes #573. Initialize arrays in mkiau GC #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathomp4
added
the
0 diff
sdrabenh
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #573
This PR is an attempt to fix #573 by initializing arrays. To be very safe, I initialize a lot of the allocatable arrays I saw. Probably overkill, but it can't hurt.
I've tested this with both Release and Debug flags replaying to MERRA2 and the answers are zero-diff.
I'll add @rtodling to this PR as well as touching IAU is an AGCM/ADAS special.
NOTE 1: You must run Debug without windfix due to windfix/sphere code issues. I know @wmputman has said once windfix might not be needed anymore, but I still ran Release Replay runs with it on.
NOTE 2: The file looks "more different" since my editor removes trailing whitespace.