-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve user interface of mk_runofftbl.F90 #693
Conversation
…status. Add OPTIONAL input argument to be aware of an ocean mask that is not SAME GEOS land-mask.
Adjust ocean mask 303-317 should be done before anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I trust @sanAkel that this works as intended. Approving for Surface Preproc team.
One comment: There seems to be a minor grammatical issue in the following print statement:
print*, "Working on with input BCs string: ", file
(Line 43)
to address @gmao-rreichle's (Thank you!) comment #693 (review)
@sanAkel is this PR still something you pulled in to develop? If so, we need someone from the land team such as @gmao-rreichle to actually approve this PR. If not, we should close this PR. |
@sdrabenh, I think this can be pulled in. You need another review? @gmao-rreichle already approved, see ⬇️ |
@sanAkel OK I will pull in as soon as approved. @gmao-rreichle will need to re-approve since stale reviews were dismissed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-approving
This PR:
mk_runofftbl.F90
, with default inputs.MAPL_tripolar.nc
to fetchocean mask
via call to subroutine:read_oceanModel_mask
currently returns nothing! However, it is available for future use in follow up PR.✅ Answers remain unchanged.