-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Stretched Cube Sphere option to BCS package #801
Conversation
@gmao-rreichle and @weiyuan-jiang one question: |
I suppose one question I've had is should we be more specific with the naming scheme? That is instead of Also, I think these are for longitude of -98.35 as they are over CONUS. |
@mathomp4 good catch for -98.35! I will fix this! I think @gmao-rreichle can comment more but his idea is to leave flexibility if this changes we can easily add other lats /lons. And not have super long name for boundary conditions. |
...dComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/makebcs/make_bcs_questionary.py
Show resolved
Hide resolved
@mathomp4: As @biljanaorescanin said, the string that identifies the particular Stretched CS Grid would have to be rather long, and we only have a single underscore that separates the atm grid resolution from the ocean grid resolution in the bcs naming convention. Using something like |
fix gnu error
remove print
combine stretched cs grid and regular cs grid
I've tested this and with this last commit I can reproduce all options Bill uses. We can also run all other combinations and CS grid is zero diff. |
...dComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/makebcs/make_bcs_questionary.py
Outdated
Show resolved
Hide resolved
This PR was tested after last commit on Friday Sept 15th. Since all code changes are in boundary conditions this is trivially zero diff for GCM. |
@sdrabenh : This PR is ready for merging. I approved it, and my approval should have counted towards the @GEOS-ESM/surface-preproc-team, but that failed again. I guess @mathomp4 can super-approve, assuming the two of you -- as part of the @GEOS-ESM/python-transition-team -- are ok with the python changes. |
Ahh. @gmao-rreichle I just removed you and readded you to @GEOS-ESM/surface-preproc-team . And Github Seems to have liked that. |
@mathomp4: On the PR landing page, I had just noticed a request for my review, despite my earlier approval and the page showing a green checkmark next to my name. I went ahead and approved again, which I thought then took care of the surface-preproc approval. Not sure whether your action of removing and re-adding me prompted the 2nd review button, or whether it was something else. Also, I do remember that you did the removing/re-adding a few weeks ago when we were in a similar situation. So whatever the removing/re-adding might fix, it doesn't seem to last, sadly. In any case, I think we're good to go - provided there aren't any objections to py changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python looks good. I mean, I assume it was tested.
In support of the Hazardous Weather Testbed ( HWT project) @atrayano implemented stretched grid capability. Original implementation he shared was done for old boundary conditions package so it had to be redone for python version.
This current implementation offers these choices:
Choose Stretched_Cubed-Sphere grid option:
Name Stretch Factor Lat Lon Resolution Choices
---------- ------------- ------------ ------------- ---------------------
SG001 2.5 39.5 - 98.35 c270, c540, c1080 and c2160
SG002 3.0 39.5 - 98.35 c1536
Output grid name will have stretched grid identifier for example:
CF1080x6-SG001_CF1080x6C
I'm reproducing this this PR set currently staged and used from here: /discover/nobackup/projects/gmao/osse2/stage/BCS_FILES/CF1080x6C_CF1080x6C