Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run make_bcs in different installation path #870

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

weiyuan-jiang
Copy link
Contributor

Relax the requirement of installation path from 'install/bin' to "*/bin"

@weiyuan-jiang weiyuan-jiang added the 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Dec 12, 2023
@weiyuan-jiang
Copy link
Contributor Author

@biljanaorescanin I thought you raised an issue somewhere. Can you link that issue here?

@biljanaorescanin
Copy link
Contributor

I've create issue on GEOSldas, I should have done it here: GEOS-ESM/GEOSldas#686

@gmao-rreichle gmao-rreichle marked this pull request as ready for review December 20, 2023 15:32
@gmao-rreichle gmao-rreichle requested a review from a team as a code owner December 20, 2023 15:32
Copy link
Contributor

@gmao-rreichle gmao-rreichle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed to have make_bcs work again with new install-SLES[xx]/ directories

@sdrabenh sdrabenh merged commit dead05d into develop Dec 21, 2023
15 checks passed
@sdrabenh sdrabenh deleted the feature/wjiang/intallation_path branch December 21, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) hotfix Urgent!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants