Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In running GFDL + NH + GF2020 + RRTMGP + GOCART Data runs for @FlorianDeconinck, it was found that GNU runs would fail at C180+ with:
Intel runs never had this issue.
The traceback points to this code:
GEOSgcm_GridComp/GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSmoist_GridComp/Process_Library.F90
Lines 2063 to 2064 in e2b79bd
As the failure is an overflow, the thought is that we have very small or denormal
CLCN
such that division blows out the 32-bit real. So the proposed solution is to compare againsttiny
rather than just 0:Tests show this seems to fix the issue at C180 for GNU.
Tests with this fix at c24 and c48 with BACM_1M show this is zero-diff. I can't always assume this is the case, but it seems enough proof for me to label 0-diff in the sense that "Intel + Release + BACM + c48" is zero-diff.
I'll add @wmputman as a reviewer as he is the first person I think of in re this code. Though maybe @narnold1 might be better? 🤷🏼