Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable EASE M01 option in Boundary Conditions Package #914

Merged
merged 5 commits into from
Mar 20, 2024

Conversation

biljanaorescanin
Copy link
Contributor

This grid and resolution combination is very computationally expensive to run.
With this message in the BCS package, we want to let users know this resolution is available to use or to run and create with the package, but they need special instructions on how to do it on Discover.

There is a draft readme file with a bit more information located here:
/discover/nobackup/projects/gmao/bcs_shared/test/NL3/readme_ease_m01

This PR is 0-diff Trivial since change is part of the boundary conditions package.

@biljanaorescanin biljanaorescanin added enhancement New feature or request 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) labels Mar 4, 2024
@gmao-rreichle
Copy link
Contributor

@biljanaorescanin: I edited the new warning message and clarified a couple of existing error messages. When you get a chance, please make sure the revised python script still works as intended.

@weiyuan-jiang: We might want to use (or add?) a python error/warning function to make the error/warning messages more consistent across our python code and easier to invoke from within python scripts. This should probably be done in a separate PR.

@gmao-rreichle

@biljanaorescanin biljanaorescanin marked this pull request as ready for review March 13, 2024 18:05
@biljanaorescanin biljanaorescanin requested a review from a team as a code owner March 13, 2024 18:05
@sdrabenh sdrabenh merged commit 7110ca9 into develop Mar 20, 2024
9 checks passed
@sdrabenh sdrabenh deleted the feature/borescan_ease_mo1_exit branch March 20, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants