Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix and update cice6 parameters #920

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fix and update cice6 parameters #920

merged 1 commit into from
Apr 25, 2024

Conversation

zhaobin74
Copy link
Contributor

This PR updated some run time CICE6 params based on recent test runs.

  • 540x458
    • fix update_ocn_f (should be true)
    • set default shortwave to dEdd scheme
    • change default dEdd params
    • do not output dailies by default
  • 1440x1080
    • fix update_ocn_f (should be true)

This PR is zero diff for AMIP and coupled running with CICE4

@zhaobin74 zhaobin74 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Apr 22, 2024
@zhaobin74 zhaobin74 requested a review from a team as a code owner April 22, 2024 15:48
@zhaobin74 zhaobin74 requested a review from a team April 22, 2024 15:48
sanAkel
sanAkel approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@sanAkel sanAkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no test or comment on these, but approving to move it along.

@sdrabenh sdrabenh merged commit 38a76a2 into develop Apr 25, 2024
11 checks passed
@sdrabenh sdrabenh deleted the feature/zhaobin74/tuning-fix-cice6-params branch April 25, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdrabenh sdrabenh sdrabenh approved these changes

@sanAkel sanAkel sanAkel approved these changes

Assignees
No one assigned
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhaobin74 @sanAkel @sdrabenh