gcc14: Compile icepack data file at -O0 #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathomp4
added
the
0 diff
sdrabenh
approved these changes
Aug 19, 2024
pchakraborty
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing with gcc 14 found that the compilation of
icepack/columnphysics/icepack_shortwave_data.F90was taking...forever. This file is 9600 lines of just setting arrays withreshape:https://github.com/CICE-Consortium/Icepack/blob/4c87095256c1c599c3ccaa857a95744158751a60/columnphysics/icepack_shortwave_data.F90
There is no reason I can think of you'd need to optimize this at
-O3(though maybe @tclune has some thoughts), so for now we just say "if GNU, build at -O0". Now maybe this changes answers but even so, no one is running icepack → cice with GNU anyway, so it's essentially 0-diff.