Skip to content

Structural changes

Matthew Thompson edited this page Sep 11, 2019 · 1 revision

Pull requests that are structural are ones that, say, rename or move a directory, or add a new directory that does not yet interact with the rest of the model. By all accounts they should be zero-diff, but this should not be assumed. For example, CMake can often have side-effects if changes to things like build flags are not done properly (i.e., some CMake changes can be public and affect its dependencies).

Thus, structural changes must still obey the zero diff testing paradigm of GEOS.

Examples of structural changes:

  • Moved a directory
  • Added new directory or external
  • ...