Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add the capability to read the GEOSIT forcing #688

Merged
merged 9 commits into from
Dec 7, 2023
Merged

add the capability to read the GEOSIT forcing #688

merged 9 commits into from
Dec 7, 2023

Conversation

gmao-qliu
Copy link
Contributor

I edited the file so GEOSldas can use the GEOSIT lat/lon output files (w/wo corrected precipitation) as forcing.

gmao-rreichle
gmao-rreichle reviewed Dec 5, 2023
View reviewed changes
src/Components/GEOSldas_GridComp/GEOSmetforce_GridComp/LDAS_Forcing.F90 Outdated
@@ -4957,6 +5018,23 @@ subroutine parse_G5DAS_met_tag( met_path_in, met_tag_in, date_time, &

end if

elseif (met_tag_out(1:18)=='cross_d5924_GEOSIT') then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmao-qliu : for consistency with RPIT/FPIT, I think we need to keep the GEOS version in the "cross" stream definition. As was the case with RPIT/FPIT, a future version of GEOS-IT might be produced with a newer GEOS system but still under the "GEOS-IT" name. This change requires you do edit the MET_TAG in your LDAS.rc file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just fixed the typo in line 5021, should be "d5294". All works after the fix. @gmao-rreichle

@gmao-rreichle
Copy link
Contributor

@gmao-qliu : I added one commit with a few minor changes:
51b900d?diff=split&w=1
Except for the tweak of the GEOS-IT "cross" stream MET TAG (see comment above), the edits should not change anything and be zero-diff from the previous commit. Please take a look and try a brief simulation to verify. Thanks!

@gmao-rreichle gmao-rreichle added the enhancement New feature or request label Dec 7, 2023
@gmao-rreichle gmao-rreichle marked this pull request as ready for review December 7, 2023 16:13
@gmao-rreichle gmao-rreichle requested a review from a team as a code owner December 7, 2023 16:13
gmao-rreichle
gmao-rreichle approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@gmao-rreichle gmao-rreichle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

successfully 0-diff tested for full suite of GEOSldas nightly tests on 6 and 7 Dec 2023

@gmao-rreichle gmao-rreichle merged commit 71a6d61 into develop Dec 7, 2023
5 checks passed
@gmao-rreichle gmao-rreichle deleted the feature/qliu/read_geosit_forcing branch December 7, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmao-rreichle gmao-rreichle gmao-rreichle approved these changes

Assignees
No one assigned
Labels
0-diff enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmao-qliu @gmao-rreichle