Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated to regrid.pl for gocart2g #231

Merged
merged 8 commits into from
Dec 16, 2021
Merged

Updated to regrid.pl for gocart2g #231

merged 8 commits into from
Dec 16, 2021

Conversation

bena-nasa
Copy link
Collaborator

@bena-nasa bena-nasa commented Nov 15, 2021 •
edited by mathomp4
Loading

Update regrid.pl for gocart2g. Add the new restart names as well as use the new interp_restart.x (netcdf) or interp_restarts_bin.x (binary) depending on the restart type of the upper air restarts.

Note this depends on:

@bena-nasa
modify regrid.pl to handle gocart2g restarts as well as use the new s…
af7a4bd 
…plit netcdf/binary interp_restarts.x program
@bena-nasa bena-nasa requested a review from a team as a code owner November 15, 2021 21:24
@bena-nasa bena-nasa added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. enhancement New feature or request labels Nov 15, 2021
@bena-nasa bena-nasa requested a review from mathomp4 November 15, 2021 21:25
@bena-nasa bena-nasa requested a review from a team as a code owner November 15, 2021 21:28
@mathomp4 mathomp4 added the Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Nov 29, 2021
@mathomp4
Copy link
Member

Adding DNA blocker since this requires the updates in other repos

@mathomp4 mathomp4 mentioned this pull request Dec 8, 2021
Merged
@mathomp4
Copy link
Member

mathomp4 commented Dec 9, 2021 •
edited
Loading

My tests are showing this is non-zero-diff to current GEOS regridding.

FVdycoreCubed_GridComp v1.4.1 has a fix for this from @bena-nasa

@mathomp4 mathomp4 removed the Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Dec 9, 2021
@sdrabenh sdrabenh merged commit 9e39271 into main Dec 16, 2021
@sdrabenh sdrabenh deleted the feature/bmauer/refactor_interp_restart branch December 16, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdrabenh sdrabenh sdrabenh approved these changes

@mathomp4 mathomp4 Awaiting requested review from mathomp4

Assignees
No one assigned
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bena-nasa @mathomp4 @sdrabenh