Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes aircraft max_tail, GEOSIT resource files #323

Open
wants to merge 9 commits into
base: GEOS-IT
Choose a base branch
from

Conversation

elakkraoui
Copy link

-Updates observing system for GEOSIT (seviri end date, fixed OMI, fixed prepbufr frequency).

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@elakkraoui elakkraoui requested a review from a team as a code owner April 28, 2023 17:20
@mathomp4
Copy link
Member

Note: The CI here (and in all GEOS-IT PRs) will fail until I can figure out how to fix it up on the GEOS-IT branch so that the CI picks the right version of the fixture (and Baselibs).

Note 2: The CI Build is not required to pull in PRs here. So things can still be merged with Approval.

@mathomp4 mathomp4 requested a review from rtodling April 28, 2023 19:03
@mathomp4 mathomp4 requested a review from a team as a code owner May 1, 2023 15:06
@mathomp4
Copy link
Member

mathomp4 commented May 1, 2023

@elakkraoui I've pushed in a fix for the CI. Hopefully that'll do it.

Note, it might fail again when you press the "Update branch" button...but hopefully not!

@rtodling rtodling added enhancement New feature or request Non 0-diff The changes in this pull request are non-zero-diff bugfix This fixes a bug labels Sep 22, 2023
@rtodling
Copy link
Collaborator

These are not zero-diff in general - only over certain periods

Copy link
Collaborator

@rtodling rtodling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look fine by me, but the OPS group should certify these are in sync w/ what they have - which I am not sure of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This fixes a bug enhancement New feature or request Non 0-diff The changes in this pull request are non-zero-diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants