Skip to content

Commit

Permalink
ams: In dust and sea-salt, changed dimensions back to `globalCellCoun…
Browse files Browse the repository at this point in the history
…tPerDim` since these are needed to determine emission tuning parameters, not to allocate arrays.
  • Loading branch information
amdasilva authored and sdrabenh committed May 31, 2023
1 parent 730fd26 commit 5731a90
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 9 deletions.
8 changes: 7 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Added

### Changed

### Fixed

### Changed
## [sdr_v2.1.2.7] - 2023-05-31

### Fixed

- In dust and sea-salt, changed dimensions back to `globalCellCountPerDim` since these are needed to determine emission tuning parameters, not to allocate arrays.

## [sdr_v2.1.2.6] - 2023-05-06

Expand Down
7 changes: 5 additions & 2 deletions ESMF/GOCART2G_GridComp/DU2G_GridComp/DU2G_GridCompMod.F90
Original file line number Diff line number Diff line change
Expand Up @@ -399,10 +399,13 @@ subroutine Initialize (GC, import, export, clock, RC)
VERIFY_(STATUS)
self => wrap%ptr

call MAPL_GridGet (grid, localCellCountPerDim=dims, __RC__ )
! Global dimensions are needed here for choosing tuning parameters
! ----------------------------------------------------------------
call MAPL_GridGet (grid, globalCellCountPerDim=dims, __RC__ )

! Dust emission tuning coefficient [kg s2 m-5]. NOT bin specific.
! ---------------------------------------------------------------
! TO DO: find a more robust way to implement resolution dependent tuning
! ----------------------------------------------------------------------
self%Ch_DU = Chem_UtilResVal(dims(1), dims(2), self%Ch_DU_res(:), __RC__)
self%Ch_DU = self%Ch_DU * 1.0e-9

Expand Down
12 changes: 6 additions & 6 deletions ESMF/GOCART2G_GridComp/SS2G_GridComp/SS2G_GridCompMod.F90
Original file line number Diff line number Diff line change
Expand Up @@ -355,15 +355,15 @@ subroutine Initialize (GC, IMPORT, EXPORT, CLOCK, RC)
VERIFY_(STATUS)
self => wrap%ptr

! Get dimensions
! ---------------
call MAPL_GridGet (grid, localCellCountPerDim=dims, __RC__ )
! Global dimensions are needed here for choosing tuning parameters
! ----------------------------------------------------------------
call MAPL_GridGet (grid, globalCellCountPerDim=dims, __RC__ )
km = dims(3)
self%km = km

! Scaling factor to multiply calculated
! emissions by. Applies to all size bins.
! ----------------------------------------
! Scaling factor to multiply calculated emissions by. Applies to all size bins.
! TO DO: find a more robust way to implement resolution dependent tuning
! -------------------------------------------------------------------------------
self%emission_scale = Chem_UtilResVal(dims(1), dims(2), self%emission_scale_res(:), __RC__)

! Get DTs
Expand Down

0 comments on commit 5731a90

Please sign in to comment.