Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typos and Bugs in Dust ExtData #109

Closed
mathomp4 opened this issue Feb 28, 2022 · 0 comments · Fixed by #112
Closed

Typos and Bugs in Dust ExtData #109

mathomp4 opened this issue Feb 28, 2022 · 0 comments · Fixed by #112
Assignees
@mathomp4
Labels
bug Something isn't working

Comments

@mathomp4
Copy link
Member

@lizziel of Harvard recently made a PR on MAPL (GEOS-ESM/MAPL#1377) that was checking for file existence in ExtData. It found a bug in the Dust ExtData RC file a la this line:

GOCART/ESMF/GOCART2G_GridComp/DU2G_GridComp/DU2G_GridComp_ExtData.rc

Line 25 in 150f6b8

climDUDP001 'kg m-2 s-1' Y N 0 0.0 1.0 DUDP001 ExtData/chemistry/MERRAero/v0.0.0/sfcdR_MERRA-AA-r2.aer_Nx.2003_2014.2008clm.nc4

As you can see, this:

ExtData/chemistry/MERRAero/v0.0.0/sfcdR_MERRA-AA-r2.aer_Nx.2003_2014.2008clm.nc4

should be:

ExtData/chemistry/MERRAero/v0.0.0/sfc/dR_MERRA-AA-r2.aer_Nx.2003_2014.2008clm.nc4

with a slash after sfc.

I'll make a hotfix PR soon.
@mathomp4 mathomp4 added the bug Something isn't working label Feb 28, 2022
@mathomp4 mathomp4 self-assigned this Feb 28, 2022
mathomp4 added a commit that referenced this issue Feb 28, 2022
@mathomp4
Fixes #109. Correct Dust ExtData
28e66a1
@mathomp4 mathomp4 mentioned this issue Feb 28, 2022
Closed
@mathomp4 mathomp4 mentioned this issue Feb 28, 2022
Merged
@mathomp4 mathomp4 linked a pull request Feb 28, 2022 that will close this issue
Fixes #109. Correct Dust ExtData #112
Merged
amdasilva added a commit that referenced this issue Feb 28, 2022
@amdasilva
Merge pull request #112 from GEOS-ESM/bugfix/mathomp4/#109-fix-dust-e…
5f9b655 
…xtdata

Fixes #109. Correct Dust ExtData
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mathomp4 mathomp4

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@mathomp4