Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to support Spack #115

Merged
merged 4 commits into from
Mar 17, 2022
Merged

Updates to support Spack #115

merged 4 commits into from
Mar 17, 2022

Conversation

mathomp4
Copy link
Member

This zero-diff PR has build system changes to support the use of Spack. Most of the changes just make the GEOS CMake look more like canonical CMake. GEOS previously couldn't support this, but it now can.

See GEOS-ESM/GEOSgcm#387 for overall issue.

@mathomp4 mathomp4 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Mar 10, 2022
@mathomp4 mathomp4 self-assigned this Mar 10, 2022
@mathomp4 mathomp4 changed the base branch from main to develop March 10, 2022 13:32
@mathomp4
Copy link
Member Author

Scott has pulled in GEOS-ESM/GEOSgcm#388. Therefore, I feel safe undrafting this.

@mathomp4 mathomp4 marked this pull request as ready for review March 17, 2022 14:34
@mathomp4 mathomp4 requested review from a team as code owners March 17, 2022 14:34
adarmenov
adarmenov previously approved these changes Mar 17, 2022
tclune
tclune previously approved these changes Mar 17, 2022
Copy link
Contributor

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMake changes good.

amdasilva
amdasilva previously approved these changes Mar 17, 2022
Copy link
Collaborator

@amdasilva amdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me...

@amdasilva amdasilva dismissed stale reviews from tclune, adarmenov, and themself via dc06be4 March 17, 2022 20:44
Copy link
Collaborator

@amdasilva amdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough to me...

@mathomp4 mathomp4 requested a review from tclune March 17, 2022 20:49
@amdasilva amdasilva merged commit 109ea35 into develop Mar 17, 2022
@amdasilva amdasilva deleted the feature/mathomp4/spack branch March 17, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants