Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/mmanyin/delete code artifact #170

Merged
merged 3 commits into from
Aug 23, 2022
Merged

Feature/mmanyin/delete code artifact #170

merged 3 commits into from
Aug 23, 2022

Conversation

mmanyin
Copy link
Contributor

@mmanyin mmanyin commented Aug 8, 2022

This is zero diff.
Remove the declaration of the routine "disable_convection", which is no longer used.

@mmanyin mmanyin added the 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Aug 8, 2022
@mmanyin mmanyin requested a review from a team as a code owner August 8, 2022 19:08
amdasilva
amdasilva approved these changes Aug 23, 2022
View reviewed changes
Copy link
Collaborator

@amdasilva amdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good for now. We will need to revisit this once we disable wet removal in MOIST.

amdasilva
amdasilva approved these changes Aug 23, 2022
View reviewed changes
Copy link
Collaborator

@amdasilva amdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@amdasilva amdasilva merged commit 015eaa6 into develop Aug 23, 2022
@amdasilva amdasilva deleted the feature/mmanyin/delete_code_artifact branch August 23, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amdasilva amdasilva amdasilva approved these changes

Assignees
No one assigned
Labels
0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmanyin @amdasilva