Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOAA UFS integration #24

Merged
merged 39 commits into from
Mar 4, 2021
Merged

NOAA UFS integration #24

merged 39 commits into from
Mar 4, 2021

Conversation

rmontuoro
Copy link
Contributor

This PR introduces code under development at NOAA aimed at integrating GOCART into the Unified Forecast System (UFS) weather model. It includes:

  • A NUOPC-based interface implementing a UFS-compliant GOCART model component, in the new ESMF/UFS subdirectory
  • Updates to the build system to build GOCART without Baselibs using standalone libraries, and to compile with 32-bit floating point variables

Note that the provided NUOPC/UFS cap enables MAPL to run under UFS, allowing for a potentially faster integration of components from the GEOS ecosystem into UFS in the future.

rmontuoro and others added 30 commits October 8, 2020 11:39
@rmontuoro
Remove dependency from GEOS_Shared.
f9cc26e
@rmontuoro
Enable standalone build and install based on
ec617aa 
external libraries.
@rmontuoro
Add template file for UFS GOCART component.
e64858e 
Implement BUILD_UFS option to selectively build
UFS GOCART.
@rmontuoro
Use proper name for CMake variable.
ab8e8f6
@rmontuoro
Ensure GOCART is built wih 32-bit REALs.
1c4f5d8
@rmontuoro
Remove unnecessary dependency.
86d55e1
@rmontuoro
Combined update featuring:
c313483 
- initialize, run, and finalize MAPL Cap
- enable single NUOPC run phase
- enable running GOCART2G grid component
- add NUOPC import and export fields
- add NUOPC field diagnostics
- export NUOPC imported tracer as imported
- provide imported grid from NUOPC fields to
  MAPL Cap gridded component, which can be
  passed to GOCART2G gridded component thanks
  to preliminary changes to MAPL
@rmontuoro
Remove exported test field by aerosol gridded component.
4eddcbc
@WilliamJamieson @rmontuoro
Added initial pass at setting NUM_BANDS for UFS SS configuration
4adfef4
@rmontuoro
Use proper variable to check return code.
d9b860c
@rmontuoro
Update diagnostic output and replace undeclared variable.
c506fd4
@rmontuoro
Continue to connect available imported meteorological
a8d2559 
and surface fields, compute unavailable import fields,
export updated tracers, and improve field diagnostics.
@rmontuoro
Update MAPL APIs to set grid and clock to NUOPC-provided objects.
0c9a48f
@rmontuoro
Remove unneded dependency on the FLAP package.
f61984a
@rmontuoro
Check for proper field status and use more generic MAPL
923c964 
API to explicitly complete MAPL fields with unallocated
data. Deallocate temporary arrays.
@rmontuoro
Improve MAPL field diagnostic.
5d04005
@rmontuoro
Export sea salt diagnostic quantities.
780c0ca 
Properly import fields on interface (edge) levels.
@rmontuoro
Improve mapping of imported 3D fields to GOCART internal
11d3730 
fields. Fill unmapped local levels by replicating values
from closest level of imported fields.
@rmontuoro
Import instantaneous 3D non-convective liquid and
3ec5849 
ice precipitation fluxes, along with instantaneous
normalized soil wetness.
@rmontuoro
Use updated MAPL Cap set_grid() API available
d1d18c9 
since release 2.5.0.
@rmontuoro
Import instantaneous 3D cloud fraction.
58e78f9
@rmontuoro
Merge branch 'feature/esherman/gocart2g_develop_MAPLconst' into featu…
99360c2 
…re/ufs_develop
@rmontuoro
Complete merge by adding missing CMakeLists.txt section.
b0454b8
@rmontuoro
Connect advected tracer for GOCART CA (both oc and bc)
c294f90 
and NI components.
@rmontuoro
Use proper gas constant for dry air to compute air density.
b3665b4
@rmontuoro
Properly map imported instantaneous 3D non-convective
5151fd9 
ice precipitation flux to GOCART variable.
@rmontuoro
Map imported lake fraction to GOCART variable.
8f34104
@rmontuoro
Increase field map size.
21cfabc
@rmontuoro
Add missing MAPL dependency.
4e8157c
@rmontuoro
Update MAPL APIs according to current MAPL development
065b579 
version, and properly handle MAPL return codes.
@rmontuoro rmontuoro requested a review from a team as a code owner March 1, 2021 18:41
mathomp4
mathomp4 reviewed Mar 1, 2021
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
tclune
tclune requested changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one embedded question and request for modifying the 32-bit enforcer.

@tclune
Copy link
Contributor

tclune commented Mar 1, 2021

Yes - in fact was trying to ping you in Teams when I saw your GitHub response. If NOAA is confident they won't use it, GEOS certainly does not need it.

@tclune
Copy link
Contributor

tclune commented Mar 1, 2021

If it is needed in some debugging scenarios, it could/should be converted to pflogger calls.

@WilliamJamieson
Copy link
Contributor

If it is needed in some debugging scenarios, it could/should be converted to pflogger calls.

You are referring to all these "debugging" prints throughout GOCART2G?

@WilliamJamieson
Copy link
Contributor

@rmontuoro we just merged some changes onto develop could you merge these changes onto this branch and check that it still works?

@rmontuoro rmontuoro mentioned this pull request Mar 2, 2021
Merged
WilliamJamieson
WilliamJamieson suggested changes Mar 2, 2021
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
tclune
tclune previously approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to freeze this PR. It is very big and every time a change is made we need to review it again.

WilliamJamieson
WilliamJamieson suggested changes Mar 3, 2021
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
WilliamJamieson
WilliamJamieson approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@WilliamJamieson WilliamJamieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest commit appears to have resolved all my concerns.

gmao-esherman
gmao-esherman approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@gmao-esherman gmao-esherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified this does not break GOCART2G, and is zero-diff.

@tclune tclune merged commit b62e40d into develop Mar 4, 2021
@tclune tclune deleted the feature/rmontuoro/ufs-integration branch March 4, 2021 20:54
@WilliamJamieson WilliamJamieson mentioned this pull request Mar 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmao-esherman gmao-esherman gmao-esherman approved these changes

@WilliamJamieson WilliamJamieson WilliamJamieson approved these changes

@tclune tclune tclune left review comments

@mathomp4 mathomp4 Awaiting requested review from mathomp4

Assignees

@rmontuoro rmontuoro

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rmontuoro @tclune @WilliamJamieson @mathomp4 @gmao-esherman