Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better chem Mie table error checking #34

Merged
merged 7 commits into from
Mar 10, 2021
Merged

Better chem Mie table error checking #34

merged 7 commits into from
Mar 10, 2021

Conversation

WilliamJamieson
Copy link
Contributor

This is PR addresses the fact that there are many un-handled return codes within the Chem Mie Table, by adding simple rc checking and returns.

@WilliamJamieson WilliamJamieson added the enhancement New feature or request label Mar 5, 2021
@WilliamJamieson WilliamJamieson requested a review from tclune March 5, 2021 22:13
tclune
tclune previously approved these changes Mar 8, 2021
View reviewed changes
@WilliamJamieson WilliamJamieson marked this pull request as ready for review March 9, 2021 20:07
@WilliamJamieson WilliamJamieson requested a review from a team as a code owner March 9, 2021 20:07
@gmao-esherman gmao-esherman merged commit 4759aa0 into develop Mar 10, 2021
@mathomp4 mathomp4 deleted the feature/wjamieson/Mie_table_rc branch August 11, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adarmenov adarmenov adarmenov approved these changes

@tclune tclune tclune left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WilliamJamieson @tclune @adarmenov @gmao-esherman