Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CircleCI to use large, and update components.yaml #55

Merged
merged 3 commits into from
May 19, 2021
Merged

Update CircleCI to use large, and update components.yaml #55

merged 3 commits into from
May 19, 2021

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented May 10, 2021 •
edited
Loading

This PR updates the CircleCI to use the large resource due to resumption of paid plan.

In order to debug why this was failing at first, I also updated the components.yaml to something that is usable on discover for debugging.

@mathomp4 mathomp4 added the 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label May 10, 2021
@mathomp4 mathomp4 self-assigned this May 10, 2021
@mathomp4 mathomp4 requested a review from a team as a code owner May 10, 2021 16:07
@mathomp4 mathomp4 changed the title Update CircleCI to use xlarge Update CircleCI to use large May 11, 2021
@mathomp4 mathomp4 requested a review from a team as a code owner May 13, 2021 12:58
@mathomp4 mathomp4 changed the title Update CircleCI to use large Update CircleCI to use large, and update components.yaml May 13, 2021
@mathomp4 mathomp4 added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. and removed 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) labels May 13, 2021
@mathomp4
Copy link
Member Author

Query to @gmao-esherman and @christophkeller: The components.yaml in GOCART develop still points to a HEMCO branch, GEOS/develop. Is there a tag we should use instead?

gmao-esherman
gmao-esherman approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@gmao-esherman gmao-esherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me.

@mathomp4 mathomp4 mentioned this pull request May 19, 2021
Merged
@tclune tclune merged commit 531bc15 into develop May 19, 2021
@tclune tclune deleted the feature/mathomp4/enable-xlarge-ci-gocart branch May 19, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmao-esherman gmao-esherman gmao-esherman approved these changes

@tclune tclune tclune approved these changes

Assignees

@mathomp4 mathomp4

Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathomp4 @tclune @gmao-esherman