In HISTORY, allow arithmetic involving a bundle field

[mmanyin]

HISTORY supports the output of bundle fields, it also supports arithmetic on fields, but it does not allow these two in combination, i.e. it does not allow arithmetic involving bundle fields. Could this feature be added? An example "use case" would be the units conversion of Increment bundle fields. Thanks for considering this.

[mathomp4]

I'll assign @bena-nasa and @atrayano as they have the best shot at seeing if this is doable.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days, it will be closed. You can add the "long term" tag to prevent the Stale bot from closing this issue.

[mathomp4]

@bena-nasa Has this been enabled/fixed?

[mmanyin]

@tclune This is the PR that I mentioned. It has particular value for doing units conversion, in the context of a monthly output collection.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days, it will be closed. You can add the "long term" tag to prevent the Stale bot from closing this issue.

[mmanyin]

I'm hoping that @bena-nasa still has this on his radar : - )

[mathomp4]

I will label as long-term

[bena-nasa]

@mmanyin Might have some time finally to explore and see if it is feasible

[mmanyin]

@bena-nasa great -- thanks!

[bena-nasa]

@mmanyin
I finally had a chance to look at bundle arithmetic. I thought it was going to be hopeless or at least require a lot code reorganization, but I think I did without having change a huge amount of code, shocked at how little I had to change really... Hopefully this is still useful.
I need to test more and make sure I haven't broken and remove the ridiculous amount of comments I had to put in the code to figure out how the heck this all worked...

[mathomp4]

and remove the ridiculous amount of comments I had to put in the code to figure out how the heck this all worked...

Quoth @tclune "pFlogger DEBUG time!" 😄

[mmanyin]

@bena-nasa
That is great news! Very useful (still)! Thanks for all the work on this.

[bena-nasa]

@mmanyin
It wasn't the :: in the name. Looks like it is the field splitting. Hit problems in the aer_x collection. I can output bundles just fine as long as there the field splitting is turned off (and I comment out the things in the collection that are to be split).

Unfortunately I can't test the splitting in my standalone tester for history/extdata but looks I need to figure out how to since that will just be so much more efficient.

[bena-nasa]

@mmanyin
I got it working. I will make a PR.

What is NOT working still is combining the splitting and arithmetic. I'm just not sure if this is feasible. I would really understand how the splitting works to see if the issue I'm seeing can be resolved.

[mmanyin]

@bena-nasa
Thank you. Our email exchange from Jan 29/30 identified the splitting + arithmetic problem as a separate issue. But I never opened an "issue" on GitHub, in part because I didn't want to divert focus from the work that you just did.