Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bmauer/fixes #2440 #2670

Merged
merged 10 commits into from
Mar 25, 2024
Merged

Feature/bmauer/fixes #2440 #2670

merged 10 commits into from
Mar 25, 2024

Conversation

bena-nasa
Copy link
Collaborator

Fixes issue #2440
This allows one to do arithmetic expressions with bundles.
How, still no arithmetic allowed with any collection that has the split field option.
I also added some new features to ExtDataDriver.x to add a bundle to the export state so I could debug this

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@bena-nasa bena-nasa added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Mar 22, 2024
@bena-nasa bena-nasa requested a review from a team as a code owner March 22, 2024 20:55
atrayano
atrayano previously approved these changes Mar 22, 2024
@mathomp4
Copy link
Member

Looks like exactly one ExtData case is failing? Interesting.

@bena-nasa
Copy link
Collaborator Author

Looks like exactly one ExtData case is failing? Interesting.

Yep, I just reproduced, case18, that's weird. I'l investigate.

@mathomp4 mathomp4 merged commit 8e44b29 into develop Mar 25, 2024
29 checks passed
@mathomp4 mathomp4 deleted the feature/bmauer/fixes-#2440 branch March 25, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🎁 New Feature This is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants