Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask sampler for geostationary satellite #2600

Merged
merged 19 commits into from
Mar 11, 2024
Merged

Conversation

metdyn
Copy link
Contributor

@metdyn metdyn commented Feb 13, 2024

Description

Mask array is used when observation resolution is higher than the MODEL.
When obs locations are at 500 m resolution in ABI and AHI, we want to output loc stream points from the cubed sphere grid, corresponding to the masked positions and their nearest neighbor halo points on CS.

Other added functions:

  • Add mask sampler for geostationary satellite (GEOS-R series)
  • Add geostation name into NC for station sampler
  • Add mapping between the IODA loc_index and trajectory NC output loc_index
  • Corrected a _RETURN in subroutine MAPL_GetGlobalHorzIJIndex (@weiyuan-jiang), when I realized my run crashes otherwise. Only after the ESMF_functionalities are called using global PE, then partial PE can return with success.
Screenshot 2024-02-13 at 2 29 51 PM

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@metdyn metdyn requested review from a team as code owners February 13, 2024 21:31
base/MAPL_ObsUtil.F90 Outdated Show resolved Hide resolved
base/MAPL_ObsUtil.F90 Outdated Show resolved Hide resolved
base/MAPL_ObsUtil.F90 Outdated Show resolved Hide resolved
base/MAPL_ObsUtil.F90 Outdated Show resolved Hide resolved
base/MAPL_ObsUtil.F90 Outdated Show resolved Hide resolved
base/Plain_netCDF_Time.F90 Outdated Show resolved Hide resolved
base/Plain_netCDF_Time.F90 Outdated Show resolved Hide resolved
base/Plain_netCDF_Time.F90 Outdated Show resolved Hide resolved
@mathomp4 mathomp4 requested a review from tclune February 16, 2024 18:36
tclune
tclune previously approved these changes Feb 16, 2024
@metdyn
Copy link
Contributor Author

metdyn commented Feb 21, 2024

I want to hold the PR to check the file change history

@metdyn metdyn closed this Feb 21, 2024
@metdyn
Copy link
Contributor Author

metdyn commented Mar 5, 2024

Fixed a few bugs in the sampler code.

  • Add allocate(X, _STAT) to sampler codes
  • Skip destroy_regen_grid when list(n)%end_alarm is active (the last time step in sampler)
  • Add extract_unquoted_item(STR1) to fix a string bug in geoval_xname(mx_ngeoval) in trajectory sampler

@metdyn metdyn reopened this Mar 5, 2024
@tclune tclune self-requested a review March 11, 2024 19:43
tclune
tclune previously approved these changes Mar 11, 2024
@metdyn metdyn added the 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Mar 11, 2024
@tclune tclune merged commit 60cf928 into develop Mar 11, 2024
29 checks passed
@tclune tclune deleted the feature/ygyu/mask_Feb_12 branch March 11, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants