-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store regrid weights #2631
Store regrid weights #2631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should deallocate ims and jms at the bottom of MAPL_GiedGet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is unfortunate that we needed such substantial changes in ESMFRegridder, as the MAPL3G version is much cleaner. OTOH, this probably helps us to "get it right" in 3g rather than rushing to get something working in there.
@tclune Yeah, but unfortunately I can't think of significantly cleaner way to do this. And this is not anywhere close to what we could do. As you say we really need to encode everything about the route handle in way so this is just scratching the surface... |
I was not critiquing your change - just came out wrong. I meant I'd rather have treated this layer as frozen as it has been superseded. But ... as we cannot yet use MAPL3 for the full model, and we need the capability "now" ... we must implement it twice. |
This PR provide several things. With the regridding weights which should be a big help at large resolutions/core counts
These weights are of course specific to a particular layout so only for a longer run where multiple executions of the model will be done and the layout doesn't change.
This should make a big difference on higher resolution runs. Even at say c180 though it still dramatically reduces the ExtData run time for a day by a factor 5 to 6
Bill claims at large core counts the writing may have issues, but since this is off by default should not harm. I will see if I can reproduce, if so though, we would have to bring up with ESMF.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: